Re: [Scst-devel] Compiling scst-svn (3.0 pre2)

[Bart V. A. <bva...@ac...>]

On 05/22/14 20:41, deeepdish wrote:
> I'm trying to compile scst-svn (3.0 pre2) against the 3.10.el7 kernel on
> a Fedora 20 machine I setup for this purpose and am running into a few
> issues. 
> 
> # svn checkout svn://svn.code.sf.net/p/scst/
> <http://code.sf.net/p/scst/>svn/trunk scst-svn
> 
> By no means am I a developer, however it appears that my environment
> isn't picking up the kernel major/minor versions correctly to parse
> through compile time macros.   
> 
> I compiled the 3.10.0 rl7 kernel as per the following procedure (largely
> abbreviated from https://fedoraproject.org/wiki/Building_a_custom_kernel):
> 
> The following ran against kernel-3.10.0-121.el7.src.rpm that was
> obtained from the RHEL 7 RC source tree.
> 
> rpmdev-setuptree
> yum-builddep <kernel>.src.rpm
> rpm -Uvh kernel-<version>.src.rpm
> cd ~/rpmbuild/SPECS
> rpmbuild -bp --target=$(uname -m) kernel.spec
> cd ~/rpmbuild/SOURCES/
> patch -p1 < /root/scst-svn/srpt/patches/kernel-3.10-pre-cflags.patch
> patch -p1 < /root/scst-svn/scst/kernel/scst_exec_req_fifo-3.10.patch
> patch -p1 <
> /root/scst-svn/scst/kernel/in-tree/Makefile.drivers.Linux-3.10.patch
> patch -p1 <
> /root/scst-svn/scst/kernel/in-tree/Kconfig.drivers.Linux-3.10.patch
> patch -p1 <
> /root/scst-svn/iscsi-scst/kernel/patches/put_page_callback-3.10.patch
> cd ~/rpmbuild/SPECS
> vi kernel.spec
> rpmbuild -bb --target=`uname -m` kernel.spec
> rpm -ivh kernel-<version>.rpm
> rpm -ivh kernel-devel-<version>.rpm
> rpm -ivh kernel-headers-<version>.rpm

None of the "in-tree" patches are necessary for rebuilding the RHEL 7
kernel. The scst_exec_req_fifo-3.10 patch applies cleanly and is
probably fine for RHEL 7. But the put_page_callback patch doesn't apply
cleanly and hence will have to be ported to RHEL 7. Please don't apply
the put_page_callback patch before it has been ported to RHEL 7.

> I receive the following error:
> 
> /root/scst-svn/scst/src/scst_lib.c:9746:2:error: too few arguments to
> function ‘vfs_unlink’
>   vfs_unlink(path->dentry->d_parent->d_inode, path->dentry);

Apparently RHEL 7 contains a backport of a >= 3.13 vfs_unlink patch. A
fix for this compile error has been checked in on the trunk and on the
2.2 branches.

> /root/scst-svn/scst/src/scst_main.c:58:2: warning: #warning Patch
> scst_exec_req_fifo-<kernel-version> was not applied on your kernel.
> Pass-through dev handlers will not work. [-Wcpp]
>  #warning Patch scst_exec_req_fifo-<kernel-version> was not applied on \
> 
> /root/scst-svn/iscsi-scst/kernel/iscsi.c:32:2: warning: #warning Patch
> put_page_callback-<kernel-version>.patch not applied on your kernel or
> CONFIG_TCP_ZERO_COPY_TRANSFER_COMPLETION_NOTIFICATION config option not
> set. ISCSI-SCST will be working with not the best performance. Refer
> README file for details. [-Wcpp]
>  #warning Patch put_page_callback-<kernel-version>.patch not applied on
> your \

I'm afraid that this means that none of these two patches has been
applied properly. Can you try to rebuild the RHEL 7 kernel with
scripts/rebuild-rhel-kernel-rpm, a script that is present in the SCST tree ?

Thanks,

Bart.