From: Richard S. <rea...@gm...> - 2010-09-04 03:29:45
|
On Fri, Sep 3, 2010 at 6:15 PM, Richard Sharpe <rea...@gm...> wrote: > On Fri, Sep 3, 2010 at 2:01 PM, Richard Sharpe > <rea...@gm...> wrote: >> On Fri, Sep 3, 2010 at 1:42 PM, Vladislav Bolkhovitin <vs...@vl...> wrote: >>> Timm Essigke, on 08/31/2010 02:04 AM wrote: >>>> >>>> One more thing: >>>> Turning debugging off by "make debug2perf" leaves "EXTRA_CFLAGS += >>>> -DCONFIG_SCST_DEBUG" in scst_local/Makefile, which prevents the module >>>> from loading. Please fix this glitch soon. >>> >>> Well, that's Open Source, so you can fix that yourself. It isn't anything >>> with programming, it's just few sed/shell commands called from Makefiles. >>> The current behavior is wrong and scst_local should switch to the release >>> mode as well. Looks like Richard just forgot about it. >> >> I'll get right on that tonight :-) Although Timm could have been nicer >> in asking ... > > Hmmm, on a freshly checked out scst, I get this: > > make release2debug > cd scst && make release2debug > make[1]: Entering directory `/root/scst/trunk/scst' > cd src && make release2debug > make[2]: Entering directory `/root/scst/trunk/scst/src' > sed -i.aa s/"#EXTRA_CFLAGS += > \-DCONFIG_SCST_EXTRACHECKS"/"EXTRA_CFLAGS += > \-DCONFIG_SCST_EXTRACHECKS"/ Makefile > sed failed OK, I figured it out. I should do 'make debug2release' first. Can I suggest that the shell scripting and the defines be turned into an include or something? That way they only need to be defined in one place, and any Makefile can get this facility by including the correct file. -- Regards, Richard Sharpe |