Menu

#90 Develop

closed
nobody
None
2026-03-15
2026-03-15
Anonymous
No

Originally created by: nirmalakhanza

replace bad version with good version on lib folder, append API features, append dedication documentation folder and append tests

Discussion

  • Anonymous

    Anonymous - 2026-03-15

    Originally posted by: roomote-v0[bot]

    Rooviewer Clock   See task

    Re-reviewed after merge commit ae0c4cf. The new changes only delete old admin files and Ionicons assets. All 5 previously flagged API issues remain unresolved.

    • [ ] Broken require_once paths in src/api/index.php -- all API requests will fatal error
    • [ ] ApiRouter::convertToRegex() produces invalid named capture groups -- all parameterized routes return 404
    • [ ] ApiController constructor enforces auth before child controllers can set requiresAuth = false -- public endpoints reject unauthenticated users
    • [ ] ApiAuth::authenticateWithToken() references $result['pwd_hash'] which is not in the SQL SELECT -- bearer token auth always fails
    • [ ] display_errors is unconditionally enabled in src/api/index.php -- exposes internals in production


    Previous reviews


    Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.
     

    Related

    Tickets: #1

  • Anonymous

    Anonymous - 2026-03-15

    Ticket changed by: nirmalakhanza

    • status: open --> closed
     

Log in to post a comment.

MongoDB Logo MongoDB