Menu
▾
▴
#96 Compiler warnings in SQRat code
SuperTux might be using Sqrat soon. Because we treat all warnings as errors in the submodule, I fixed (or set to ignore) all the compiler warnings that get thrown.
You can find a diff here: https://github.com/SuperTux/sqrat/commit/50f43cf339f42e9e47121a4f450e3d406df58b46
Looks good! I try to fix any warnings I see in my use, but I only compile using GCC and I also don't use all the features of Sqrat in my projects (i.e. not all templates compiled)
Last edit: Wizzard 2017-12-14
Var<SQChar*>::Var(HSQUIRRELVM vm, SQInteger idx) :
"const SQChar* ret = value;"
needs to use a reference with a const cast (like it did before) or it will always be null see : https://stackoverflow.com/questions/32779079/c-why-cant-we-convert-char-to-const-char
On Var::push() renaming the argument from value to var should be done in more cases (still has the same name as the member variable "T* const value" in many places)
HSQOBJECT obj is already initialized with sq_getstackobj() in Var::Var(HSQUIRRELVM vm, SQInteger idx). Var::value also seems to be initialized twice now :P
The "#pragma GCC diagnostic" should be in an ifdef. Visual Studio 2015 complains about the unknown name.
The rest seems to work fine
Are your notes specifically referencing this patch?
As a side note (since you seem to be doing some work on Sqrat at the moment):
If you manage to submit a pull request that cleans up the accepted issues, I'd greatly appreciate it.
Currently, I'm just stacking up what little issues there are with Sqrat.
My thoughts are that I'll get around to it sometime, but I'm busy developing other software.
Yes.
Will commit the patches soon.
renaming the argument from value to val is now commited :)
Thx!
Cleaning up old issue that was already fixed AFAIK