#103 Function::Evaluate doesn't handle native closures correctly when SCRAT_NO_ERROR_CHECKING is undefined

[shatteredmoon]

Function::Evaluate doesn't handle native closures correctly when SCRAT_NO_ERROR_CHECKING is undefined.

Line 241 of sqratFunction.h (no param version, but that doesn't seem to matter):
if (SQ_SUCCEEDED(sq_getclosureinfo(vm, -2, &nparams, &nfreevars)) && (nparams != 1)) {

This will fail every time because calling a native closure seems to always return 0 for nparams, regardless of the number of params passed.

Not sure if that's a problem with Squirrel (in sq_getclosureinfo) or Sqrat.

[Wizzard]

This is definitely an issue with Sqrat. You're not really supposed to call sq_getclosureinfo on a native closure. The most correct thing to do would be to ignore this check if it's a native closure. However, it might also suffice just to add a nparams != 0 check to all the Evaluate functions. I'll accept a pull request if you add the checks in and can verify it fixes the issue.

[Wizzard]

if (SQ_SUCCEEDED(sq_getclosureinfo(vm, -2, &nparams, &nfreevars)) && (nparams != 1) && (nparams != 0)) {

[Wizzard]

Fixed by https://sourceforge.net/p/scrat/code/ci/6758c0010cdcabab0bcc033f64a4d01d7ec3a9a9/