Pepper segfaulted when I did
pepper -bgit loc > connect.svg
on a fairly large repo (Github/CONNECT-solution/CONNECT). It said
fetching revisions ... done
then segfault. I've attached the Mac crash report.
Thanks for the bug report! I'm on vacation and won't be able to fix this right now as a first look suggests that this may be caused by a non-obvious race condition. If you feel adventurous, you can try changing new GitRevisionPrefetcher(m_gitpath); to new GitRevisionPrefetcher(m_gitpath, 1); at src/backends/git.cpp:700 (github.com).
Sorry for the inconvenience,
Jonas
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I'm sorry for the long delay on this one. I've tracked down quite a few glitches with pepper on Mac OS X. The error you described was most likely caused by my usage of pthread_join(). I don't exactly know what was wrong with it, but I changed the joining mechanism (now with a wait condition; see 8123dece). The latest version on Github is working fine on my MacBook now.
It's been a while since you opened the bug, so I assume you moved to other tasks. I'm marking this bug resolved but will leave it open for comments. If you get a chance to confirm or deny that it's working now, it would be great if you could leave a note.
Thanks a lot!
Jonas
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi Neil,
Thanks for the bug report! I'm on vacation and won't be able to fix this right now as a first look suggests that this may be caused by a non-obvious race condition. If you feel adventurous, you can try changing
new GitRevisionPrefetcher(m_gitpath);tonew GitRevisionPrefetcher(m_gitpath, 1);at src/backends/git.cpp:700 (github.com).Sorry for the inconvenience,
Jonas
Hi Neil,
I'm sorry for the long delay on this one. I've tracked down quite a few glitches with pepper on Mac OS X. The error you described was most likely caused by my usage of pthread_join(). I don't exactly know what was wrong with it, but I changed the joining mechanism (now with a wait condition; see 8123dece). The latest version on Github is working fine on my MacBook now.
It's been a while since you opened the bug, so I assume you moved to other tasks. I'm marking this bug resolved but will leave it open for comments. If you get a chance to confirm or deny that it's working now, it would be great if you could leave a note.
Thanks a lot!
Jonas