#950 Motorola 68000 syntax highlighting patch

open
Scintilla (358)
5
2012-08-20
2012-08-19
Anonymous
No

Hi,

I am the author of the original 68k lexer ( http://sourceforge.net/tracker/index.php?func=detail&aid=3101598&group_id=2439&atid=352439 ).

I use, for a while now, some patches which improve a lot the lexer. It also fixes a non-recognized instruction, fixes "equate" declarations used for libraries, etc...
Here a part of the History:

- 10 jul 2011 Improved a lot the code, it is now smaller, faster, simpler...
Completed Doxygen keywords list

- 01 jul 2011 Added local labels in macros (forgot them !)

- 08 nov 2010 Improved Labels/Declaration handling

- 07 nov 2010 Fixed 'bset.l' instruction in lexer (typo)

The attached .zip file provides a new LexA86k.cxx (smaller than a .patch file), a new sample, and a new xml file, with updated colors (based on Kate color scheme, so it's less toyish...).
There are also 3 small patches for the headers of Scintilla (I use them to build my patch against Code::Blocks).

I use this version of the lexer for more than one year now, without any problem.

Thanks in advance.

Discussion

  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2012-08-19

    This archive contains the patch files.

     
    Last edit: Anonymous 2014-03-14
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2012-08-19
    • summary: Motorola 68000 syntax hilighting patch --> Motorola 68000 syntax highlighting patch
     
  • Neil Hodgson

    Neil Hodgson - 2012-08-20

    To preserve binary compatibility between Scintilla and applications, styles should never be renumbered.

    Some non-ASCII filters (sc.ch < 0x80) were removed. While not all were needed, non-ASCII values must not be passed to ctype functions like isalpha or isdigit. Doing so may reference out-of-bounds memory and cause runtime failures.

     
  • Neil Hodgson

    Neil Hodgson - 2012-08-20
    • assigned_to: nobody --> nyamatongwe
     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2012-08-20

    Ok. Do you want that I do these modifications, or do you do them by yourself ?

     
    Last edit: Anonymous 2013-11-04
  • Neil Hodgson

    Neil Hodgson - 2012-08-21

    Its best if you do them, particularly the ASCII checking code since it can influence control flow. Every function found with \&lt;is[a-z] may fail with non-ASCII characters. I avoid ctype wherever possible because of this and its why the CharacterSet class was created.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks