#841 highlight current line, i.e. screen line

[notjohn]

Highlighting the current line on long wrapped text is a pain. It does not help, it hinders.

Please only highlight the physical cursor line edge to edge.

[Neil Hodgson]

If this is implemented, it should be an option.

Since I do not use line highlighting, I will not work on this feature myself.

[Zufu Liu]

Same as https://sourceforge.net/p/scintilla/feature-requests/1245/

[Zufu Liu]

Attachment contains an implementation that works for Notepad2 (can be toggled from menu View -> Highlight Current LIne -> Highlight Subline), https://github.com/zufuliu/notepad2/commit/405b8218cbc820e455618484edad40303ddc0edd

I don't figured out why the same changes not works for SciTE (by hardcoded caretLine.subLine = true; in ViewStyle::Init()).

[Neil Hodgson]

I don't figured out why the same changes not works for SciTE (by hardcoded caretLine.subLine = true; in ViewStyle::Init()).

The default (on layer 0) is to change the background colour of the line in ViewStyle::Background when its the caret line. This uses LineLayout::containsCaret which is set in EditView::PaintText without checking whether its in the subline.

[Neil Hodgson]

Logically, LineLayout should be const for drawing and changing it to reflect local context is a kludge. Perhaps its time to move containsCaret, hotspot, xHighlightGuide and potentially others into a new argument to drawing. The difficult case is brace highlighting as that patches styles which can then be treated uniformly.

[Zufu Liu]

Patch to remove the hotspot field, as it only used inside DrawBackground() and DrawForeground(), it can be removed completely.

[Neil Hodgson]

Committed with minor edits as [46ec6c].

[Zufu Liu]

Move subline checking into EditView::PaintText() indeed fixed highlighting bug for base layer + background color.

const int caretOffset = static_cast<int>(posCaret.Position() - model.pdoc->LineStart(lineCaret));
// ...
ll->containsCaret = !hideSelection && (lineDoc == lineCaret)
    && (ll->lines == 1 || !vsDraw.caretLine.subLine || ll->InLine(caretOffset, subLine));

The change seems will not affects other usages of containsCaret.

[Neil Hodgson]

Committed with minor edits as [d72368].