#509 Multiple bug fixes and feature enhancements

Completed
closed
None
5
2009-04-28
2008-07-03
Jason Oster
No

Here is a complete list of the work I've down on Scintilla over the past few weeks. The attachment contains the original files (from the current CVS repository), the fully patched files, and all individual diffs.

LexCPP.cxx:
* Fix fold point on the last line in the document (related to #1943442)

LexCSS.cxx:
* Fix fold point on the last line in the document (related to #1943442)

LexHTML.cxx:
* Fix fold point on the last line in the document (#1943442)
* Fix coloring of word characters at the end of the document.
* Add support for PHP 5.3.0 NOWDOC syntax, and fix delimiter handling of HEREDOC syntax.
* Fix PHP </script> handling. (related to #1839569)
* Fix line break handling with string variables at the end of lines.

The fold point fixes should also be applied to other lexers with similar problems. I have not had a use for any other lexer yet, so it is not currently a priority for me.

Discussion

  • Jason Oster

    Jason Oster - 2008-07-03

    Conglomerate patches.

     
  • Neil Hodgson

    Neil Hodgson - 2008-07-06
    • assigned_to: nobody --> nyamatongwe
     
  • Neil Hodgson

    Neil Hodgson - 2008-07-06

    Logged In: YES
    user_id=12579
    Originator: NO

    This fold modification can (temporarily) remove a fold point on the last visible line, causing folded text to unfold. For example, see
    http://www.scintilla.org/beforeType.PNG
    http://www.scintilla.org/beforeType.PNG

    Maintaining the fold structure is much more important than ensuring the last line looks correct since the user may have spent some effort arranging the folding. The CSS and HTML versions of the fold patch may be better but its the C++ folder that has been worked on the most - I couldn't find an example that folded better with the patch than without. It may actually be simpler to just limit the display of the fold structure on the final line.

    Committed the other changes.

     
  • Jason Oster

    Jason Oster - 2008-07-08

    Logged In: YES
    user_id=643076
    Originator: YES

    Ah, thank you for pointing that out. I was wondering why the C++ folding code was so much different from HTML/CSS. This is good to know, I will have to study the fold structure more closely.

     
  • Neil Hodgson

    Neil Hodgson - 2009-04-28

    Released in 1.78.

     
  • Neil Hodgson

    Neil Hodgson - 2009-04-28
    • milestone: --> Completed
    • status: open --> closed
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks