Menu

#1289 Add support for CMake function/endfunction

Committed
closed
5
2019-06-09
2019-05-23
Alex
No

CMake has 2 types of function definitions: macro/endmacro and function/endfunction. Scintilla only supports the former: https://sourceforge.net/p/scintilla/code/ci/default/tree/lexers/LexCmake.cxx#l87

I request to add support for function and treat it just like macro

Discussion

  • Neil Hodgson

    Neil Hodgson - 2019-05-23
    • labels: --> scintilla, lexer, cmake
    • assigned_to: Neil Hodgson
     
  • Neil Hodgson

    Neil Hodgson - 2019-05-23

    This will require someone to provide an implementation of the change. As I do not use CMake, I will not be working on this myself.

     
    • Jad Altahan

      Jad Altahan - 2019-05-24

      I have patches for OP's request; however, I should also mention that functions are part of CMake 3, which added more new features to the scripting language (see #1270). Our lexer does not currently have any of the new goodies.

       
      👍
      1
      • Alex

        Alex - 2019-05-26

        The patches look good to me. IMO the bracket comment and arguments are not important (never seen them used) but the quoted argument is. The current lexer does recognize quoted text, so I don't see urgent need for changes besides the ones from this issue.

         
  • Neil Hodgson

    Neil Hodgson - 2019-05-28
    • Group: Completed --> Committed
     
  • Neil Hodgson

    Neil Hodgson - 2019-05-28

    Committed patches as [03bbd7] and [7a7dd3].

     

    Related

    Commit: [7a7dd3]
    Commit: [03bbd7]

  • Neil Hodgson

    Neil Hodgson - 2019-06-09
    • status: open --> closed
     
  • Neil Hodgson

    Neil Hodgson - 2019-06-09

    Committed patches as [03bbd7] and [7a7dd3].

     

    Related

    Commit: [7a7dd3]
    Commit: [03bbd7]


Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.