Menu

#1213 Use UTF8BytesOfLead to make UTF8Classify clean

Committed
closed
scintilla (293)
5
2018-05-14
2018-03-24
Zufu Liu
No

Use UTF8BytesOfLead to make UTF8Classify() clean.

Script GenerateCharTable.py not committed in [feature-requests:#1211].

3 Attachments

Related

Feature Requests: #1211

Discussion

  • Neil Hodgson

    Neil Hodgson - 2018-03-24
    • labels: --> scintilla
    • Group: Completed --> Committed
     
  • Neil Hodgson

    Neil Hodgson - 2018-03-24

    Committed as [5f2c12].

    Reordered the tests in testUniConversion.cxx so they match the new checking order in UTF8Classify. Added some more tests for a single invalid 2nd or 3rd trail byte.

    I don't believe the generation script is needed as its results will never change. Removed the script comment in [07f35a].

     

    Related

    Commit: [07f35a]
    Commit: [5f2c12]

  • Zufu Liu

    Zufu Liu - 2018-03-25

    Indeed the table not changed, but as it's not written by hand, I think it's better to keep these utils in the repo.

     
    • Neil Hodgson

      Neil Hodgson - 2018-03-25

      The script is attached to this feature request in the unlikely event that anyone wants to examine it. Including it in the repo makes it look like there may be some point to running it.

       
  • Neil Hodgson

    Neil Hodgson - 2018-05-14
    • status: open --> closed
     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.