#1165 Tab draw mode (files attached)

Committed
closed
scintilla (88)
5
2016-12-05
2016-11-11
dail8859
No

Some editors allow tabs to be draw different from just the regular "arrows". This patch addes 2 new API messages that get/set the tab draw mode. There is currently 2 ways of drawing them. The "long arrow" which is the normal/default way, and as a "strike out" which is a single horizontal line (like the arrow but with no arrow head). This is how Sublime text does and maybe others. Someone could also add a new mode like "short arrows" like what MSVC uses.

The default (long arrow):

And strike out:

This patch also does a slight bit of renaming, for example "DrawTabArrowFn" is now "DrawTabFn" since tabs don't technically have to be arrows.

Feedback and/or renaming suggestions welcome.

8 Attachments

Discussion

  • Neil Hodgson

    Neil Hodgson - 2016-11-12

    Changing DrawTabArrowFn to DrawTabFn (and related changes) is an unnecessary incompatibility with existing platform layers. Arrows don't have to have heads.

     
    Last edit: Neil Hodgson 2016-11-12
    • dail8859

      dail8859 - 2016-11-12

      Changing DrawTabArrowFn to DrawTabFn (and related changes) is an unnecessary incompatibility with existing platform layers.

      Ah yes I see that now.

      Is this patch something you would accept if I reverted the naming changes?

       
  • Neil Hodgson

    Neil Hodgson - 2016-11-14
    • labels: --> scintilla
    • assigned_to: Neil Hodgson
    • Group: Completed --> Committed
     
  • Neil Hodgson

    Neil Hodgson - 2016-12-05
    • status: open --> closed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks