Cool, how fast this new lexer got adpoted and extended. Feeling responsible as the original author of this module, I will review the patch. Tomorrow if I get to it.
After a first quick look:
In the documentation of the SRecord project, another file format named "Textronix HEX" is described. So I would suggest naming this lexer and related functions/symbols "tehex" instead of "thex".
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Changes should be made to Scintilla.iface, not SciLexer.h as it is generated from Scintilla.iface.
SCE_HEX_RECTYPE_UNKNOW needs to end with 'N' to make sense and match others.
Appears to be based on previous version as the patch doesn't apply cleanly:
Command Error
abort: patch failed to apply
Hunk #1 succeeded at 64 with fuzz 1 (offset 11 lines).
Hunk #4 FAILED at 776
1 out of 4 hunks FAILED -- saving rejects to file lexers/LexHex.cxx.rej
[Code: 255]
here the requested changes
SCLEX_THEX needed to be added to Scintilla.iface. Committed with that addition as [e2f615].
Related
Commit: [e2f615]
Cool, how fast this new lexer got adpoted and extended. Feeling responsible as the original author of this module, I will review the patch. Tomorrow if I get to it.
After a first quick look:
In the documentation of the SRecord project, another file format named "Textronix HEX" is described. So I would suggest naming this lexer and related functions/symbols "tehex" instead of "thex".
Nice work, I couldn't find issues, just did some cleanup and extension.
Committed as [3554de], [7a1825], [273431], [165f9d], [400c8a], [01ed56], [30f8f3], and [efb76e].
Related
Commit: [efb76e]
Commit: [01ed56]
Commit: [165f9d]
Commit: [273431]
Commit: [30f8f3]
Commit: [3554de]
Commit: [400c8a]
Commit: [7a1825]
Just for reference an example .tek file.