Menu

#1086 New annotation display style, ANNOTATION_INDENTED

Committed
closed
scintilla (295)
3
2014-12-05
2014-11-13
No

Hi Neil!

Thanks for Scintilla!

We're using annotations to display compile error messages inline, and since we want the messages indented we use ANNOTATION_BOXED. In some cases the box outline is drawn over parts of the text. See attached image where underscores in Courier New are effectively erased. (This is on windows, Scintilla 3.5.1, using GDI)

I don't think this a bug - where else would you draw the box. Instead I suggest an ANNOTATION_INDENTED display style which roughly does not do the line drawing at the end of EditView::DrawAnnotation.

What do you think? Is it worth the trouble? I don't mind doing a draft implementation.

Best,
Erik

1 Attachments

Discussion

  • Neil Hodgson

    Neil Hodgson - 2014-11-14
    • labels: --> scintilla
    • assigned_to: Neil Hodgson
     
  • Neil Hodgson

    Neil Hodgson - 2014-11-14

    While it would be an OK addition, you could just choose a font that doesn't place underscores so low such as Lucida Sans Unicode.

     
  • Erik Angelin

    Erik Angelin - 2014-11-14

    Yes, Courier New won't be our default font :) Anyhow, here is a patch.

     
  • Neil Hodgson

    Neil Hodgson - 2014-11-16
    • Group: Completed --> Committed
     
  • Neil Hodgson

    Neil Hodgson - 2014-11-16

    Committed as [523ab7].

     

    Related

    Commit: [523ab7]

  • Neil Hodgson

    Neil Hodgson - 2014-12-05
    • status: open --> closed
     

Log in to post a comment.