The lexer contains a list of known entries that would be better implemented using Scintilla's keyword mechanism since that allows updating the list without recompiling.
There's some use of is* that may be unsafe outside ASCII and there may be other issues that should be addressed.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Will someone be fixing issues such as those mentioned earlier?
If you want to do so then please attach a copy that protects calls of isalnum, isalpha, etc with IsASCII or similar. Also replace the hard-coded word list with keywords in a similar manner to other lexers.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Main commit [8e8695] differs from attachment by reordering header inclusion to match scripts/HeaderOrder.txt . IsNextEntryStart was unused so was removed by [f0cf02].
Does the author of the lexer want it integrated?
The lexer contains a list of known entries that would be better implemented using Scintilla's keyword mechanism since that allows updating the list without recompiling.
There's some use of is* that may be unsafe outside ASCII and there may be other issues that should be addressed.
Yes, the author would like it to be integrated.
Will someone be fixing issues such as those mentioned earlier?
If you want to do so then please attach a copy that protects calls of isalnum, isalpha, etc with IsASCII or similar. Also replace the hard-coded word list with keywords in a similar manner to other lexers.
Like this?
Committed as [8e8695], [f0cf02], [a873bb].
Main commit [8e8695] differs from attachment by reordering header inclusion to match scripts/HeaderOrder.txt . IsNextEntryStart was unused so was removed by [f0cf02].
Related
Commit: [8e8695]
Commit: [a873bb]
Commit: [f0cf02]