#1012 Submit an improved makefile lexer

Completed
open
nobody
lexer (49)
5
2013-09-23
2013-08-26
Gur Stavi
No

An improved makefile lexer for GNU makefiles.

1 Attachments

Discussion

<< < 1 2 (Page 2 of 2)
  • Gur Stavi

    Gur Stavi - 2013-09-22

    Fix bug in Make folding

     
  • Neil Hodgson

    Neil Hodgson - 2013-09-23

    As mentioned before, LexCommon should be merged into the lexer files. In this case modularity trumps code duplication.

    Too many type names pollute the global namespace without being all that unique such as PosBank. The unnamed namespace can be used to cage those names.

    Are the MIB keywords really so unchanging that they should be hardcoded in the lexer instead of being set by the app?

    scintilla\lexlib\LexCommon.h:40: warning: Member variable 'DoLexContext::lexer' is not initialized in the constructor.
    scintilla\lexlib\LexCommon.h:40: warning: Member variable 'DoLexContext::userPtr' is not initialized in the constructor.
    scintilla\lexlib\LexCommon.h:40: warning: Member variable 'DoLexContext::startPos' is not initialized in the constructor.
    scintilla\lexlib\LexCommon.h:40: warning: Member variable 'DoLexContext::length' is not initialized in the constructor.
    scintilla\lexlib\LexCommon.h:40: warning: Member variable 'DoLexContext::doneStyling' is not initialized in the constructor.
    scintilla\lexers\LexMib.cxx:346: style: Unused variable: tmpStr

    Spelling: ketwords

    *.iface should not be in file.patterns.make since that implies it can be run with make.

     
<< < 1 2 (Page 2 of 2)

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks