#2400 Build fails on Windows in non-English environment

[Tsuyoshi Miyake]

When I try to build the sources on Windows in non-English (Japanese) environment, it fails. See the details here: notepad-plus-plus/notepad-plus-plus#13991

I have attached a suggested fix as attachement, but just in case this is the diff of Scintilla.vcxproj which I'd like to modify

diff --git a/scintilla/win32/Scintilla.vcxproj b/scintilla/win32/Scintilla.vcxproj
index 2911afdd..2225ebcd 100644
--- a/scintilla/win32/Scintilla.vcxproj
+++ b/scintilla/win32/Scintilla.vcxproj
@@ -97,6 +97,7 @@
       <MultiProcessorCompilation>true</MultiProcessorCompilation>
       <MinimalRebuild>false</MinimalRebuild>
       <DebugInformationFormat>ProgramDatabase</DebugInformationFormat>
+      <AdditionalOptions>/source-charset:utf-8 %(AdditionalOptions)</AdditionalOptions>
     </ClCompile>
     <Link>
       <SubSystem>Windows</SubSystem>

[Zufu Liu]

SciTE.vcxproj and CXXFLAGS inside scintilla.mak or scite.mak needs similar (/source-charset:utf-8 or just /utf-8) change.

[Tsuyoshi Miyake]

@zufuliu attached is a suggestion of scintilla.mak (and just in case the diff is as follows). I can't find "SciTE.vcxproj" in the repo.

diff --git a/scintilla/win32/scintilla.mak b/scintilla/win32/scintilla.mak
index 3ac956df..05581bad 100644
--- a/scintilla/win32/scintilla.mak
+++ b/scintilla/win32/scintilla.mak
@@ -36,7 +36,7 @@ SUBSYSTEM=-SUBSYSTEM:WINDOWS,10.00
 !ENDIF

 CRTFLAGS=-D_CRT_SECURE_NO_DEPRECATE=1 $(ADD_DEFINE)
-CXXFLAGS=-Zi -TP -MP -W4 -EHsc -std:c++17 $(CRTFLAGS)
+CXXFLAGS=-Zi -TP -MP -W4 -EHsc -std:c++17 -utf-8 $(CRTFLAGS)
 CXXDEBUG=-Od -MTd -DDEBUG
 CXXNDEBUG=-O2 -MT -DNDEBUG -GL
 NAME=-Fo

[Neil Hodgson]

Committed with [cf5b20] and [11c642].

[Zufu Liu]

scite.mak is not updated.

[Neil Hodgson]

scite.mak does not (currently) compile any files containing UTF-8. The files containing UTF-8 are either in Lexilla or Scintilla and are compiled into libraries by the makefiles in those projects then linked or loaded into SciTE.

To allow easy debugging of all code, SciTE.vcxproj compiles everything in Lexilla, Scintilla, and SciTE so needs the flag.