Menu ▾ ▴

#2281 crash with SCFIND_CXX11REGEX when more then MAXTAG matches

Bug
closed-fixed
nobody
scintilla (604) regex (9) search (4)
6
2021-09-22
2021-09-01
Ferdinand Oeinck
No

When using the search flags SCFIND_REGEXP|SCFIND_CXX11REGEX, and using more than 10 groups in the searchtext parameter of the SCI_SEARCHINTARGET message, scitilla 5.11 on Windows crashes at line 296 of file RESearch.cxx: 'pat[i].clear();'

The actual bug is present at lines 3202 to 3208 of Document.cxx were a (co < MAXTAG) check is missing before changing the search object members bopat, eopat and pat.

I can work around this bug by using the (?: ) construct instead of ( ). But anyhow scintilla should not crash here!

Discussion

  • Ferdinand Oeinck

    Ferdinand Oeinck - 2021-09-01

    The file Document.cxx has changed here. The correct line numbers are 3212 to 3218

     

  • Neil Hodgson

    Neil Hodgson - 2021-09-02
    • labels: --> scintilla, regex, search
    • status: open --> open-fixed
    • Priority: 1 --> 6
     

  • Neil Hodgson

    Neil Hodgson - 2021-09-02

    Committed fix as [fbff1a].

     

    Related

    Commit: [fbff1a]

  • Neil Hodgson

    Neil Hodgson - 2021-09-22
    • status: open-fixed --> closed-fixed
     

  • Neil Hodgson

    Neil Hodgson - 2021-09-22

    Committed fix as [fbff1a].

     

    Related

    Commit: [fbff1a]

Log in to post a comment.