#2268 Cocoa View leaks memory

[Arne Scheffler]

The cocoa implemention leaks memory. [ScintillaView dealloc] is never called and that happens because of a circular dependency with the ScintillaCocoa c++ class.
To fix this issue the ScintillaCocoa c++ class needs to declare the sciView and delegate varaibles as weak:
__weak ScintillaView *sciView;
__weak id<scintillanotificationprotocol> delegate;
After making this change the [ScintillaView dealloc] is called when a window which contains this view is closed.</scintillanotificationprotocol>

[Neil Hodgson]

Its too big of a change to make just before a release so I'll look at this again after 5.1.1 is released.

[Neil Hodgson]

Committed fix as [ef0596].

[Neil Hodgson]

Its too big of a change to make just before a release so I'll look at this again after 5.1.1 is released.