#2248 Autocompletion popup has padding that causes issues with the scroll view (MacOS11 only)

[Petko Georgiev]

In MacOS11 a new "style" attribute was added to NSTableView. Its default value since MacOS11 is NSTableViewStyleAutomatic, which resolves to NSTableViewStyleInset for the autocompletion popup. This causes some padding/inset to be added to the four sides of the table view. This is fine for the most part, but it causes the scroll view to end up smaller than it should be.

I've attached a video showing a case where I could scroll in the popup without the scrollbar appearing and a screenshot where someone made it look cut off when the popup has only one entry.

For the video I just modified ScintillaTest to show a list of only 4 entries in the autocompletion.

[Petko Georgiev]

It appears that changing the style to NSTableViewStylePlain makes the popup look like it did before MacOS11. In my tests this change makes the popup look identical on Catalina and Big Sur. There was also a pixel above and below the row contents that don't appear in Big Sur.

@nyamatongwe, I think making it look identical on both platforms is the better choice, but if you think otherwise, then we could probably try to figure out what the inset is and increase the scrollview's height by that much. What do you think?

[Neil Hodgson]

Committed as [075d2b] .

It could be argued that this appearance is out of place on macOS 11 but its difficult to make the macOS 11 appearance work well. I did try tweaking spacing more but still had problems, including when there is an icon column. If the new appearance (or even a simulation with rounded end selections in the less intense colour) could be made to work well then it could be made an option.

An icon column can be added with something like this Lua code:

xpm1 = [[/* XPM */
static const char * Left_xpm[] = {
"20 20 11 1",
"   c None",
".  c #B6B6B6",
"+  c #626262",
"@  c #000000",
"#  c #8ED4FF",
"$  c #B1E2FF",
"%  c #48B8FF",
"&  c #FFFFFF",
"*  c #25AAFF",
"=  c #0092DC",
"-  c #007AB9",
"                    ",
"                    ",
"      ..            ",
"     .++.           ",
"    .+@@+.          ",
"   .+@#@+.......... ",
"  .+@#$@+++++++++++.",
" .+@#$%@@@@@@@@@@@@+",
".+@#&%%%#########*@+",
"+@#&%%%%%%%%%%%%%=@+",
"+@-*%%%%%%%%%%%%%=@+",
".+@-*%*===========@+",
" .+@-**@@@@@@@@@@@@+",
"  .+@-*@+++++++++++.",
"   .+@-@+.......... ",
"    .+@@+.          ",
"     .++.           ",
"      ..            ",
"                    ",
"                    "};
]]
function onOff()
    editor.AutoCSeparator = string.byte("\n")
    editor:RegisterImage(1, xpm1)
    editor:AutoCShow(0, "one?1\nthree\ntwo\nverb")
end