Menu
▾
▴
#1968 Backslash causes Scintilla to not highlight keywords
closed-fixed
nobody
5
2017-10-25
2017-08-11
No
Hiyas,
We've a proposed patch for (ancient) closed-won't-fix bug #725:
https://sourceforge.net/p/scintilla/bugs/725/
Proposed patch:
https://github.com/sqlitebrowser/sqlitebrowser/commit/f7f60365ebc8eb5ae328f93def6751e169f99b5c
Not sure if opening this ticket here was the right approach, or if there was a way to re-open #725 that I didn't see. If I got it wrong, sorry. :D
Your patch appears wrong, with the current code as the (green) 'after' state. Perhaps the patch is inverted.
Assuming the patch is inverted, it takes away control: you can no longer choose between backslash escapes and backslash doesn't escape. Why are you not setting the sql.backslash.escapes option?
I misread the code. Its probably OK but the project is currently frozen for the 4.0.0 release so it will be looked at after the release.
Committed as [ccc04e].
Related
Commit: [ccc04e]
Thanks Neil. Is there any way to get the attribution on that changed from myself to Martin Kleusberg? He wrote the patch, I just happened to have an old SF account still with which to let people know. :)
Mercurial, like Git, is immutable and trying to change published history can lead to horrible downstream failures.
The attribution in the documentation is changed with [25eea2].
Related
Commit: [25eea2]
No worries Neil, thanks. :)