#1958 doCommandBySelector: bug

[Chinh Nguyen]

There's a bug in the doCommandBySelector: method for ScintillaView.mm. The selector passed in is already
a SEL so @selector() is not necessary and respondsToSelector: will always return false.

I didn't provide a patch because in correcting this problem, pressing the delete key now deletes two characters instead of one. That's because doCommandBySelector: will now properly perform the selector for deleteBackward: and I'm assuming the keyboard handler for Scintilla also processed the delete key.

[Neil Hodgson]

This could be improved by not calling interpretKeyEvents when the key has already been handled by Scintilla.

- (void) keyDown: (NSEvent *) theEvent {
    bool handled = false;
    if (mMarkedTextRange.length == 0)
        handled = mOwner.backend->KeyboardInput(theEvent);
    if (!handled) {
        NSArray *events = @[theEvent];
        [self interpretKeyEvents: events];
    }
}

[Chinh Nguyen]

Seems to work just fine. No problem with simple test case of entering Japanese characters provided by a user. No deleting of two characters per key press of delete key either. I'll let you know if anything comes up during testing. Thank you.

[Neil Hodgson]

Fix committed as [852686].