Menu

#1817 LuaExtension.cxx checkudata() failure case

Bug
closed-fixed
5
2016-04-26
2016-03-15
No

When borrowing this code for my own purposes, I ran into a bug that checkudata can leave extra items on the stack if the call to lua_rawequal() fails then the metatable and field are left on the stack. That if statement should have an else case to pop those two off the sack.

I apologize for not having an exact way to make it fail so you can test it, but I know how hard Lua stack issues can be to debug so figured I'd drop this note here.

Discussion

  • Neil Hodgson

    Neil Hodgson - 2016-03-16
    • labels: --> scite, lua
    • status: open --> open-fixed
    • assigned_to: Neil Hodgson
     
  • Neil Hodgson

    Neil Hodgson - 2016-03-16

    Fix committed as [f83d67].

     

    Related

    Commit: [f83d67]

  • Neil Hodgson

    Neil Hodgson - 2016-04-26
    • status: open-fixed --> closed-fixed
     

Log in to post a comment.

MongoDB Logo MongoDB