#1772 Bug with edit_gotolineendvisual=End + show_line_endings=true (Geany)

Bug
closed-fixed
5
2015-11-06
2015-10-24
JP Vossen
No

I'm creating this by request from Geany https://github.com/geany/geany/issues/712.

This has been driving me nuts for a while but I finally figured it out. If you have:

  • keybindings.conf
    • edit_gotolinestart=Home
    • edit_gotolineend=End
    • edit_gotolinestartvisual=Home
    • edit_gotolineendvisual=End
  • geany.conf
    • show_line_endings=true

Then hitting end on the wrapped part of a long line does a line-down and not an end. If you set show_line_endings=true then end works as expected and desired.

I'm running Geany 1.25 from the "geany-dev" PPA on Linut Mint 17 but I'm pretty sure this bug has been present thing the whole "gotoline*visual" thing was fixed.

Steps to reproduce (Geany):
1. Set config as above
2. Create a file with long lines
3. Go to the first line of a wrapped line, hit home and end and they should stay on that line as expected
4. Go to the second (last?) line of a wrapped line, home should work but end should go to the next line instead of the end of this line
5. Set show_line_endings=false
6. end should not work as expected per the keymap.


elextr commented:

The behaviour is the same in Scite so this is a problem in the Scintilla widget we use which is a separate project (www.scintilla.org), please report it there and post the issue number here for tracking.

Discussion

  • Colomban Wendling

    Indeed, line end movement on display lines is broken when viewEOL=true. This applies to all uses of StartEndDisplayLine(), either with key movements like SCI_LINEENDDISPLAY or with magrin click selection when SC_MARGINOPTION_SUBLINESELECT is set.

    Attached patch fixes it (and should be correct, but I'm not 200% certain it doesn't have side effects I didn't expect/find, so you probably should verify this carefully too).

     
  • Neil Hodgson

    Neil Hodgson - 2015-10-26
    • labels: --> scintilla, selection
    • status: open --> open-fixed
    • assigned_to: Neil Hodgson
     
  • Neil Hodgson

    Neil Hodgson - 2015-11-06
    • status: open-fixed --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks