#1534 Drag and drop between ScintillaView's doesn't work

[Chinh Nguyen]

If you drag some text from one ScintillaView and drop to a different ScintillaView in the same application, no text is inserted into the destination ScintillaView.

I was able to fix this by changing in ScintillaCocoa.mm ScintillaCocoa::PerformDragOperation():

  bool moving = (operation & NSDragOperationMove) != 0;

to

  InnerView* contentView = ContentView();
  bool moving = ((operation & NSDragOperationMove) != 0) && (contentView == [info draggingSource]);

However, this doesn't account for two different ScintillaView's that point to the same document (for example, from a split view).

[Neil Hodgson]

Dragging between SciTE's edit and output pane works. It doesn't work with an empty destination view but that's because of code to avoid moves to the same location.

[Chinh Nguyen]

My destination view is typically empty because it's a command line view and the source view is typically an editor view.

[Neil Hodgson]

The problem may be that inDragDrop is being set when its a drag target, not a drag source. Try the attached patch.

[Chinh Nguyen]

That fixed it, thanks.

[Neil Hodgson]

Committed as [483668].