#1437 Folding support for GetText (PO) lexer

Feature_Request
closed-fixed
3
2013-01-30
2013-01-11
No

Please find the attached patch implementing folding on the GetText (PO) lexer. It's my first folding patch, so I'm really unfamiliar with this. Please tell me if anything has to be updated.

1 Attachments

Discussion

  • Colomban Wendling

    Hum, actually it's rather a feature request, sorry for the wrong tracker :(

     
  • Neil Hodgson

    Neil Hodgson - 2013-01-11

    I won't be looking at this until after 3.2.4 is released.

     
  • Neil Hodgson

    Neil Hodgson - 2013-01-11
    • status: open --> open-later
    • assigned_to: Neil Hodgson
    • milestone: Bug --> Feature_Request
    • priority: 5 --> 3
     
  • Neil Hodgson

    Neil Hodgson - 2013-01-19
    • labels: patch --> patch, scintilla, lexer
    • status: open-later --> closed-fixed
     
  • Neil Hodgson

    Neil Hodgson - 2013-01-25

    Clang 3.1 which is the version present in recent Linux distributions such as Fedora 18 warns (in --analyze mode) about unused values in the folder. The code could be simplified so that these variables have more limited scope and assigned values are used.

    clang --analyze -pthread -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng15 -I/usr/include/libdrm -I/usr/include/harfbuzz   -DNDEBUG -Os -Wall -Wno-missing-braces -Wno-char-subscripts -Wno-long-long -pedantic -DGTK -DSCI_LEXER -I ../include -I ../src -I ../lexlib -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DDISABLE_GDK_FONT  --std=c++11 -c ../lexers/LexPO.cxx
    ../lexers/LexPO.cxx:170:6: warning: Value stored to 'nextLineState' during its initialization is never read
        int nextLineState = lineState;
            ^               ~~~~~~~~~
    ../lexers/LexPO.cxx:172:6: warning: Value stored to 'nextLevel' during its initialization is never read
        int nextLevel = level;
            ^           ~~~~~
    2 warnings generated.
    
     
  • Neil Hodgson

    Neil Hodgson - 2013-01-30

    Changeset [7f106a] stops the warnings from clang --analyze.

     

    Related

    Commit: [7f106a]


Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks