#1391 cannot undo converting eols

Bug
closed-invalid
Scintilla (793)
3
2012-07-23
2012-07-18
Anonymous
No

cannot undo converting eols

Discussion

  • Neil Hodgson

    Neil Hodgson - 2012-07-18
    • assigned_to: nobody --> nyamatongwe
    • priority: 5 --> 3
    • status: open --> open-works-for-me
     
  • Neil Hodgson

    Neil Hodgson - 2012-07-18

    Works OK with SciTE 3.2.1 on Windows:
    Options | Open ada.properties
    View | End of Line
    -> [CR][LF} at each line end
    Options | Line End Characters | LF
    Options | Convert Line End Characters
    -> [LF} at each line end
    Edit | Undo
    -> [CR][LF} at each line end

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2012-07-19

    But the real eol didn't change after undo. If you type in a new line, the eol char is still the previous one.

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2012-07-19
    • status: open-works-for-me --> open
     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2012-07-19

    so it may has mixed eols in one file :(

     
  • Neil Hodgson

    Neil Hodgson - 2012-07-19

    Options are not remembered as part of undo: setting the line end character to LF and then performing undo will not change the line end character back to CRLF. Undo is only concerned with the contents of the document.

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2012-07-20

    I think EOL option is different with other option such as wrap line or show writespace or toggle bookmark.
    EOL will be written into the file finally so it's kind of the "contents" of the documents.

    I've tried create a file that have all three EOL chars (CR+LF, CR and LF) using SciTE and open the file with emacs and there shows some wrong characters.

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2012-07-20

    BTW, the documentation introduced the SCI_ADDUNDOACTION message but I think this feature is not implemented, is it?

     
  • Neil Hodgson

    Neil Hodgson - 2012-07-20
    • status: open --> open-invalid
     
  • Neil Hodgson

    Neil Hodgson - 2012-07-20

    Choosing a particular EOL option does not change the file. It is only if you then add a line end that the document changes. Allowing users to use different line ends if they want is a feature.

    SCI_ADDUNDOACTION is implemented and is included in the tests. See test/simpleTests.py.

     
  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2012-07-23

    OK I see. Your option is great. But I think allowing users to use different line ends is kind of overhead feature. It's more convenient to update the EOL char once user choosing an EOL option and keep consistency.

    It will be more clear if you choose View/End of Line, then convert the EOL.

     
  • Neil Hodgson

    Neil Hodgson - 2012-07-23
    • status: open-invalid --> closed-invalid
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks