Font leading methods are not implemented on all platforms (all methods are implemented only on GDI). While ExternalLeading() is not actually used anywhere in the code and can be left unimplemented, InternalLeading() is used when drawing text blobs and dimensioning call tips. As a result, on platforms that don't have InternalLeading() implemented, text blobs will look inferior compared to GDI, because background box won't be drawn tightly around text. The impact on call tips is minimal, though.
Attached is a patch that implements InternalLeading() on Direct2D. The remaining two platforms that are missing InternalLeading() implementation (GTK and Cocoa) would require someone else to contribute appropriate code.
Log in to post a comment.