#1314 Font leading methods not implemented on all platforms

Bug
open-accepted
Scintilla (793)
5
2012-03-03
2012-02-26
No

Font leading methods are not implemented on all platforms (all methods are implemented only on GDI). While ExternalLeading() is not actually used anywhere in the code and can be left unimplemented, InternalLeading() is used when drawing text blobs and dimensioning call tips. As a result, on platforms that don't have InternalLeading() implemented, text blobs will look inferior compared to GDI, because background box won't be drawn tightly around text. The impact on call tips is minimal, though.

Attached is a patch that implements InternalLeading() on Direct2D. The remaining two platforms that are missing InternalLeading() implementation (GTK and Cocoa) would require someone else to contribute appropriate code.

Discussion

  • Neil Hodgson

    Neil Hodgson - 2012-03-03

    Committed Direct2D InternalLeading implementation and unused variable removal.

     
  • Neil Hodgson

    Neil Hodgson - 2012-03-03
    • assigned_to: nobody --> nyamatongwe
    • status: open --> open-accepted
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks