#76 Can't modify comment to a move in Wayland

[Hong]

Running Scid vs PC on Wayland prevents comments on a move from being modified. Scid vs PC is the latest version to this day, r3483. Tested on Debian Bookworm.

1. Start up Scid vs PC.
2. Make a move on the board.
3. Open the PGN window. Right click on the move. Click "Comment Editor".
4. In Comment Editor, try to type something.

In Step 4, I couldn't type anything.

[Hong]

In the exactly the same system, using X11 doesn't have the issue.

Additionally, edit boxes in other places appear to be working, such the game editor after pressing "Ctrl-S".

[Steven]

Try clicking a few times inside the very top left of the comment editor text box to give it focus.

[Hong]

Hah, thanks, this works! It turns out I have to click on a place very close to where the cursor is supposed to stand.

[Steven]

Please test out this patch too, If this vvvv works/makes it better, i will include it. Cheers

Index: tcl/windows/comment.tcl
===================================================================
--- tcl/windows/comment.tcl (revision 3483)
+++ tcl/windows/comment.tcl (working copy)
@@ -157,6 +157,7 @@
     if {\"%W\" == {.commentWin}} {::commenteditor::storeComment}
   "
   bind $w.cf.text <Control-Return> "$w.b.ok invoke ; break"
+  bind $w.cf.text <Button-1> "focus $w.cf.text"

[Hong]

No, it doesn't make things better...

[Steven]

Thanks
For some reason this text widget doesn't always behave nicely re getting focus.
I've made a minor commit to subversion3484. with the below ifdef. Possibly it changes something, but i doubt it. Regards

Index: tcl/windows/comment.tcl
===================================================================
--- tcl/windows/comment.tcl     (revision 3482)
+++ tcl/windows/comment.tcl     (working copy)
@@ -571,6 +571,7 @@
   set offset  0
   ::board::mark::clear $board
   $text delete 1.0 end
+if {$comment != {}} {
   foreach {mark pos duplicate} [::board::mark::getEmbeddedCmds $comment] {
     foreach {type square arg color} $mark {begin end} $pos {break}  ;# set
     set square [::board::sq $square]
@@ -591,6 +592,7 @@
   }
   $text insert insert [string range $comment $offset end]
   $text mark set insert 1.0 ; # Set cursor to the top
+}