Steven,
Just a quick status update.
I was going to do it one report at time, but they all are so
interrelated, I basically had to do it all at once. So it took an extra
day or so. But the coding is complete, and the initial testing has
everything working. In addition I was able to re-enable the latex
preview buttons as well as adding a latex preview option to the player
report rather than just the opening report. Also added direct to pdf
options when the tools are available, and pdf viewing again when the
tools are installed.
Note as a part two after this patch gets vetted and ratified, I will
turn my attention to the windows world, and make sure those buttons work
there as well, but for now, they are still as before both suppressed in
windows, but I can make them work there as well, I'll just do it as a
step 2.
There is one outstanding thing that I wanted to cover before packing it
up as a (large patch). Basically one of my goals was to normalize the
latex across the board so no more chess12, and everything is upgraded to
xskak for all the latex reports. This means there is only one latex
preamble and it covers all reports, plus the export games report is
enhanced, and the code is now a bit simpler taking advantage of xskak's
move tracking etc. Though I do think after I get this all done across
all platforms, that I will come back to the in game export analysis
chart when there is computer analysis stats in a game. I think the
chart idea is interesting, and I made sure it all works, but it can use
some love to be more useful.
But it is the preamble that I wanted to deal with for the moment. There
is an options panel for editing the preamble and it stores the contents
in user data. It was simple as part of this patch to change the default
that gets created, and with death of the chess12 latex the new preamble
can take advantage of the panel that is already created for the user to
make edits if they wanted too.
However, what do I do with people that already have scid installed. They
basically have old preamble code in their options data. I don't want to
destructively overwrite, in case they have one that works for them. So
I have two choices I think:
Simple
1) The new setup can create a separate options data bit for the new
preamble. With the chess12 menu items gone, and the panel option turned
over to the new preamble, this will effectively orphan a small bit of
unused data in their options file.
Harder maybe a couple of extra days on the patch
2) Along with option 1, I could add a bit of logic to the latex option
panel to A) Tell the user the situation, and offer to remove the
orphaned options from their data file.
None of this would be noticed on fresh installs once the patch is in
place of course, it is just dealing with folks who already have it
installed, basically getting there data upgraded to the new system.
I am open to other ideas, but I just want to cover this last bit, before
this all gets packaged up.
Richard
|
