#201 Theme issues in r1519

[Drew Ferguson]

After updating to r1519 - theme issues

Clean full build; removed local .scidb-bate from homefolder

1. On startup
   Startup] '/home/drew/.scidb-beta/themes/Staunton.dat' is corrupt (unknown piece style 'Contourless|1536512761722|purple|gregor')
   [Startup] '/home/drew/.scidb-beta/themes/Fantasy.dat' is corrupt (unknown piece style 'Contourless|1536512761722|purple|gregor')

2. After changing themes then using Board tab (no data loaded); with themes clearlooks & scidblue - window does a strange, slow shrinking behaviour and once it is set as fairly small , it can be maximised. Sometimes core dumps as in 4 below

3. Core dumps after changing theme then using Board tab (no data loaded); happens with themes alt and clam,

 (func) performGetWorkArea
(file) tk_twm.cpp:6797
(what) can't use empty string as operand of "*"
(type) tcl::Error
=== Backtrace ============================================
 Tk_HandleEvent
 TkDoConfigureNotify
 Tk_MaintainGeometry

 TclServiceIdle
 Tcl_DoOneEvent

 TclNRRunCallbacks

 Tcl_EvalEx
 Tk_BindEvent
 TkBindEventProc
 Tk_HandleEvent

 TclNRRunCallbacks

 Tcl_EvalEx
 Tk_BindEvent
 TkBindEventProc
 Tk_HandleEvent

 TclNRRunCallbacks

 TclServiceIdle
 Tcl_DoOneEvent

 TclNRRunCallbacks

 Tcl_EvalEx
 Tk_BindEvent
 TkBindEventProc
 Tk_HandleEvent

 TclNRRunCallbacks

 Tcl_EvalEx
 Tk_BindEvent
 TkBindEventProc
 Tk_HandleEvent

 Tcl_ServiceEvent
 Tcl_DoOneEvent
 Tk_MainLoop
 Tk_MainEx

 __libc_start_main
==========================================================
terminate called after throwing an instance of 'tcl::Error'
Aborted (core dumped)

[Drew Ferguson]

Also received alert after loading database and changing to clearlooks - after window shrings, alerts pops up as follows

precondition violation: containsGameAt(position)

(func) game
(file) app_application.cpp:1973
(what) precondition violation: containsGameAt(position)
(type) mstl::precondition_violation_exception

=== Backtrace ============================================
  TclNRRunCallbacks

 Tcl_ServiceEvent
 Tcl_DoOneEvent

 TclNRRunCallbacks

 TclServiceIdle
 Tcl_DoOneEvent
 Tk_MainLoop
 Tk_MainEx

 __libc_start_main
==========================================================
::scidb::db::get variants {/home/drew/ChessPGN/Apr games.pgn}
LayoutSwitcher .application.nb.database.main.switcher
::database::switcher::WidgetProc .application.nb.database.main.switcher update
.application.nb.database.main.switcher update
::tk::dialog::error::bgerror {precondition violation: contains(name)}

[Gregor Cramer]

 On startup
 [Startup] '/home/drew/.scidb-beta/themes/Staunton.dat' is corrupt
 (unknown piece style 'Contourless|1536512761722|purple|gregor')
 [Startup] '/home/drew/.scidb-beta/themes/Fantasy.dat' is corrupt
(unknown piece style 'Contourless|1536512761722|purple|gregor')

Fixed with [r1520]. I have forgotten to distribute piece style Contourless.

 After changing themes then using Board tab (no data loaded); 
 withthemes clearlooks & scidblue - window does a strange, slow
 shrinking behaviour and once it is set as fairly small , it can
 be maximised.
 Sometimes core dumps as in 4 below

Fixed with [r1521]. The layout algorithm depends on accuracy, and with some styles (clam, clearlooks, scidblue) the computation wasn't accurate. Furthermore the safety of the algorithm has been improved.

Core dumps after changing theme then using Board tab (no data
loaded); happens with themes alt and clam,

Fixed with [r1520], Some themes didn't supply a specific required value, and this has been corrected.

Also received alert after loading database and changing to
clearlooks after window shrings, alerts pops up as follows

I cannot reproduce this problem, is it possible for you to reproduce it with [r1520]? I think this was a subsequent error because of the problem with window resizing, and the latter has been fixed.

[Drew Ferguson]

Confirm all issues fixed

[Gregor Cramer]

Many thanks for testing!