Menu

Commit [r991]  Maximize  Restore  History

Fixed some serious bugs in the curve fitting code, which would cause incorrect

computation results.

- bug #2102708: Weighted linear and polynomial fits required actual weights
(1/sigma^2) to be specified in place of standard errors, while all others
(as well as error bar plots) needed the standard errors themselves.
Solution: Switched everything to using standard errors, eliminating the term
"weighting" from the GUI and most of the source code.
Rationale: Avoid confusion for users, especially given the previous
inconsistent treatment of the matter. Avoid confusion for
devs. Arbitrary weights don't work naturally with non-linear fits;
and they almost certainly lead to nonsensical error estimates of
results (unless you _really_ know what you're doing, in which case
you can simply specify 1/sqrt(weight) as standard error).

- Fixed estimation of parameter errors in case of (scaled) Levenberg-Marquardt
fitting with unknown Y errors. See
http://www.gnu.org/software/gsl/manual/html_node/Computing-the-covariance-matrix-of-best-fit-parameters.html

- Fixed computation of R^2 in case of known Y errors.

knut_f 2008-09-27

changed /branches/current_stable/scidavis/src/Fit.cpp
changed /branches/current_stable/scidavis/src/Fit.h
changed /branches/current_stable/scidavis/src/FitDialog.cpp
changed /branches/current_stable/scidavis/src/FitDialog.h
changed /branches/current_stable/scidavis/src/PolynomialFit.cpp
changed /branches/current_stable/scidavis/src/fit_gsl.h
changed /branches/current_stable/scidavis/src/scidavis.sip
/branches/current_stable/scidavis/src/Fit.cpp Diff Switch to side-by-side view
Loading...
/branches/current_stable/scidavis/src/Fit.h Diff Switch to side-by-side view
Loading...
/branches/current_stable/scidavis/src/FitDialog.cpp Diff Switch to side-by-side view
Loading...
/branches/current_stable/scidavis/src/FitDialog.h Diff Switch to side-by-side view
Loading...
/branches/current_stable/scidavis/src/PolynomialFit.cpp Diff Switch to side-by-side view
Loading...
/branches/current_stable/scidavis/src/fit_gsl.h Diff Switch to side-by-side view
Loading...
/branches/current_stable/scidavis/src/scidavis.sip Diff Switch to side-by-side view
Loading...
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.