#395 Missing plot name in results log after fitting a curve

[Fellype]

After fitting a curve, the name of the graph should be added to the results log, but this is not being done, as can be seen in the attached figure.

This was verified with SciDAVis 1.26 built against:
- Qt 5.13.2 and Python 3.8.2
- Qt 4.8.7 and Python 3.8.2

No problems using Qt 4.8.7 and Python 2.7.17.

To reproduce this bug, just plot something and perform any kind of fit, or run the following python code on a note:

t = newTable("T",2,10)
for j in range(1,11):
 t.setCell(1,j,j)
 t.setCell(2,j,2*j+2)
g=plot(t,"2",2)
l=g.activeLayer()
f = LinearFit(l,"T_2")
f.fit()

[High Performance Coder]

On Sun, Apr 12, 2020 at 09:31:59PM -0000, Fellype wrote:

This was verified with SciDAVis 1.26 built against:
- Qt 5.13.2 and Python 3.8.2
- Qt 4.8.7 and Python 3.8.2

No problems using Qt 4.8.7 and Python 2.7.17.

Is this bug present in SciDaVis 2.x? We're not intending to support
1.x and Python 3.

--

---

Dr Russell Standish Phone 0425 253119 (mobile)
Principal, High Performance Coders hpcoder@hpcoders.com.au
http://www.hpcoders.com.au

---

[Fellype]

Is this bug present in SciDaVis 2.x?

Yes. Same environment as in ticket #393

We're not intending to support
1.x and Python 3.

I didn't understand what you mean. Will you drop python support on SciDAVis 2.x or will you move back to the EOLed Python 2 version?

[High Performance Coder]

On Sun, Apr 12, 2020 at 11:39:02PM -0000, Fellype wrote:

Is this bug present in SciDaVis 2.x?

Yes. Same environment as in ticket #393

We're not intending to support
1.x and Python 3.

I didn't understand what you mean. Will you drop python support on SciDAVis 2.x
or will you move back to the EOLed Python 2 version?

SciDAVis 2.x will be python3 only, not python2.

SciDAVis 1.x can be compiled against Python3, thanks to Miguel's
efforts, but is not supported in that mode (SciDAVis 1.x API assumes
Python 2 API).

Cheers

--

---

Dr Russell Standish Phone 0425 253119 (mobile)
Principal, High Performance Coders hpcoder@hpcoders.com.au
http://www.hpcoders.com.au

---

[gbm]

Attached patch solves the problem.

[Fellype]

Hi Miquel,
Thank you for the patch. It works fine here.
Best regards.

[Suthiro]

fixed here