#371 Plot Associations box causes crash

[David Goldenberg]

Hi,
It has take me quite some time, with help from my students and teaching assistants, to pin down the particular conditions that cause this crash. This happens with SciDAVis versions going back to atleast 1D8, on MacOS 10.12.6

The key elements seem to be:
1. A graph with a data curve and a fit curve.
2. Another set of data added to the graph after the fit curve was added, and with a x data column associated with it that is different than the x data set for the original data set.
3. Attempting to change the association of the new curve.
The crash occurs when the OK button of the Plot Associations dialog box.

I am attaching a project file that is primed to crash in this way. To make SciDAVis crash open this file and:
1. Select the graph window.
2. Open the add/remove curves dialog.
3. Select "Table2_A595-fit" in the list of graph contents.
4. Click the Plot Associations button.
5. Select Table2: µL BSA(X), A595-fit(Y).
6. Change the x association from µL BSA to µg BSA.
7. Click OK
Voila! SciDAVis crashes!
I am also attaching the crash report.

I have no idea how specific the conditions have to me for this crash to occur. The workaround seems to be to avoid adding new curves to graphs that already have a fit curve on them.

Thanks in advance for a fix, if possible.

David

[Fellype]

I could not reproduce the crash using a Linux (Slackware) package or a Windows one (via WINE). The SciDAVis version used was 1.23.1 in both cases. And the project file I've used is attached ¹
Maybe an issue that affect only Mac installations.

¹ @David,
Your project file was not attached...

[gbm]

I can reproduce the crash (Fedora 28, python 3.6.8, Qt 5.11.3)
The attached patch fixes the problem.

[David Goldenberg]

Many thanks to Fellype and gbm for taking a look at this, and my apologies for omitting the project file, which I am attaching now.

I was able to reproduce the crash with this file on Windows 10 and SciDAVis 1.2.3, running on virtual machine with Virtual Box.

I think that one of the key elements that leads to the crash is changing the x-axis association between columns with different x values.

In any case, it sounds like gbm has found a fix, and I look forward to seeing his patch incorporated in the Mac distribution!

Thanks again,
David

[High Performance Coder]

In any case, it sounds like gbm has found a fix, and I look forward to

seeing his patch incorporated in the Mac distribution!

Slightly bad news I'm afraid. I will be traveling over the next month, and
will not have the facility to produce a mac build for that time. If we
could persuade Apple to allow macos to run on a virtual machine that would
help, but Apple won't be persuaded. But running the windows build on wine
is always an option, if you can put up with the lack of python.

[gbm]

Meanwhile, there is a slightly better workaround than that mentioned by David.
There is no crash when adding new curves and modifying its "Plot Associations" provided you remove all 'fit (function) curves' from plot before changing plot associations.

[David Goldenberg]

HPC,
Thanks for your ongoing efforts. This is not urgent, and the patched version will be appreciated whenever it becomes available.

David

[David Goldenberg]

This appers to be fixed in the 1.25 release. Thank you!
David