#361 Issues with dark desktop themes (1.23.4, Fedora 29, GNOME 3.30.2, Adwaita-dark theme)
This has mostly to do with Qt's color choices. It's not specific to Qt4, because I'm seeing similar issues with another package I maintain in Fedora, Molsketch, which is built with Qt5.
For the most part, Qt properly detects a dark theme and makes sane(ish) color substitutions. There are some glitches here and there, e.g. the "dead space" in a file browser dialog or in the graph tree in the attached image, is rendered white, background tables have a black lettering in their title, whereas backround graphs have white, etc.. What is a bit problematic though, the axis numbers are also white, so they are invisible over a white canvas.
I've been told that Qt theming works a lot like CSS. If that is the case, perhaps it would make sense to have certain elements e.g. canvas bg, axis numbers and so on, with a predefined, reasonable value, that stays the same regardless of desktop theme tones. Unless of course someone wants to work on a dark theme…
I know that Miquel has been commiting a lot of Qt and color-related code, so if this was somehow addressed in a later snapshot, please close this.
I'm testing a Qt5 build and some things have already improved, for instance gone are the white patches of dead space. Axis numbers are still white by default.
In version 2.3.0 on Gentoo Linux with the KDE Breeze Dark theme I'm still seeing some issues with the colours. So far I've noticed unreadable text (white on white) in the about window, file open/save window, and the settings window (see attached screenshots). Likely this is a simple case of the background colour being hardcoded, while the font colour is not.
Just a quick update: Edit --> Preferences --> Colors and setting all entries to #232629 makes scidavis's colours exactly the same as the KDE Breeze Dark theme. The About window is still unreadable though, see screenshots.
Might I suggest to add a checkbox to Edit --> Preferences --> Colors that disables/enables scidavis colour overrides? In case an user does not want to change the colour from the default provided by the theme. Because now I have to use the screen colourpicker to find the correct theme colour, and manually set scidavis to adhere to that colour. While if there were a checkbox, that is disabled by default, this would work correctly out of the box, and users who do want to change the colour can still do so by checking the checkbox and selecting the desired colour.