Menu
▾
▴
#313 Failure to build on armv7hl
Fedora 27 will support quite a few architectures, namely x86_64, i686, ppc64, ppc64le, aarch64, armv7hl and s390x. SciDAVis builds fine on all of them except armv7hl. As you can see in the build.log, the failure is related to the use of anonymous namespace.
According to Fedora's guidelines "Fedora packagers should make every effort to support all primary architectures", so I would like to ask if this is something that can be easily implemented or will it complicate things for the other arches?
I expect to formally submit the scidavis package for review at the end of this month and I am going through all the checklist items for the process as my time permits. Meanwhile, people using SciDAVis from my copr haven't reported any problems so far.
Please try attached patch
Oh, it does work!
Thanks a million!
(Once again)
Why was the float version of the template commented out in the first place? It seems harmless to leave it in place.
The float version was commented out at the 'dcc9616 War on warnings' commit.
If both (float and double) templates are present, one of them (usually the float one) will trigger a '-Wunused-function' warning. That warning was removed by commit 'dcc9616'.
The armv7hl arch has no 'double' type for floating point variables, only 'float'.
Thus the 'template <> double conv ...' triggers again a '-Wunused-function' warning, while the missing (commented out) 'template <> float conv ...' triggers both the 'used but never defined' compile warning and the "undefined reference to 'float (anonymous namespace)::conv<float>(QString const&)'" link errors at end of build log.
The proposed patch removes both compile warnings and link errors.
Is this still an issue? SciDaVis currently builds on both the aarch64 and armv7l OpenSUSE targets at https://build.opensuse.org/package/show/home:hpcoder1/scidavis.
No, you can close it.