Menu

#285 SciDaVis is not compiling under GCC 6

1.14
closed
nobody
None
4normal
2016-11-28
2016-07-07
Cunio
No

Fedora 24, GCC 6.1.1, I cannot compile SciDaVis, the error I get:

src/FitDialog.cpp: In member function 'void FitDialog::showFitPage()':
src/FitDialog.cpp:658:41: error: no matching function for call to 'QTableWidgetItem::setFlags(bool)'
         it->setFlags(!Qt::ItemIsEditable);

Similar issue was observed by Debian users:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=811873

Related

SciDAVis Bugs: #285

Discussion

  • narunlifescience

    replace it->setFlags(!Qt::ItemIsEditable); with it->setFlags(Qt::ItemFlags(!Qt::ItemIsEditable));

    if you find more errors regarding such flags, place them inside Qt::ItemFlags("flag") (there should be more)

     
    • High Performance Coder

      Could you create a pull request, then close out the issue please?
      On 08/07/2016 4:51 AM, "narunlifescience" narunlifescienc@users.sf.net
      wrote:

      replace it->setFlags(!Qt::ItemIsEditable); with
      it->setFlags(Qt::ItemFlags(!Qt::ItemIsEditable));

      if you find more errors regarding such flags, place them inside
      Qt::ItemFlags("flag") (there should be more)


      Status: open
      Group: 1.D13
      Created: Thu Jul 07, 2016 10:59 AM UTC by Cunio
      Last Updated: Thu Jul 07, 2016 10:59 AM UTC
      Owner: nobody

      Fedora 24, GCC 6.1.1, I cannot compile SciDaVis, the error I get:

      src/FitDialog.cpp: In member function 'void FitDialog::showFitPage()':src/FitDialog.cpp:658:41: error: no matching function for call to 'QTableWidgetItem::setFlags(bool)'
      it->setFlags(!Qt::ItemIsEditable);

      Similar issue was observed by Debian users:
      https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=811873


      Sent from sourceforge.net because you indicated interest in
      https://sourceforge.net/p/scidavis/scidavis-bugs/285/

      To unsubscribe from further messages, please visit
      https://sourceforge.net/auth/subscriptions/

       

      Related

      SciDAVis Bugs: #285

    • Cunio

      Cunio - 2016-07-10

      @narunlifescience You are right, replacing setFlags(!Qt::ItemIsEditable); with setFlags(Qt::ItemFlags(!Qt::ItemIsEditable)); solved the problem with the compilation.

       

      Last edit: Cunio 2016-07-10
  • narunlifescience

    Done!

     
  • Alexander Ploumistos

    Can scidavis be re-introduced to F24 now or are there more kinks to iron out?

     
  • Cunio

    Cunio - 2016-07-10

    @Alexander Ploumistos I have been trying to prepare 1D13 rpms for F24 but I didn't succeed yet.

     

    Last edit: Cunio 2016-07-10
  • High Performance Coder

    Just realised that a whole bunch of new distros have been added to the openSUSE build service.

    I enabled Fedora 23 and 24 - looks like F23 builds without a hitch, but F24 has some dependency problems.

    I'll sort that out once I get my disk space under control.

     

    Last edit: High Performance Coder 2016-07-29
    • Alexander Ploumistos

      Hello,

      I am really grateful for your work on scidavis.

      Just realised that a whole bunch of new distros have been added to the openSUSE build service.

      Are you talking about this?
      https://build.opensuse.org/package/show/home:hpcoder1/scidavis

      I enabled Fedora 23 and 24 - looks like F23 builds without a hitch, but F24 has some dependency problems.

      Where can I find the successful build?

      Thank you so much!

       
      • High Performance Coder

        On Fri, Jul 29, 2016 at 11:52:07AM +0000, Alexander Ploumistos wrote:

        Hello,

        I am really grateful for your work on scidavis.

        Just realised that a whole bunch of new distros have been added to the openSUSE build service.

        Are you talking about this?
        https://build.opensuse.org/package/show/home:hpcoder1/scidavis

        I enabled Fedora 23 and 24 - looks like F23 builds without a hitch, but F24 has some dependency problems.

        Where can I find the successful build?

        Thank you so much!

        F23 failed and F24 has unresolvable dependencies.

        F23 looks like it has upgraded Qwt to Qwt 6. It is a big task to
        update scidavis to support Qwt 6, so don't expect a fix for that any time soon.

        The alternative work around is to supply a Qwt 5 package for F23/24
        from the build service. This will require some time to do this (and
        spare disk space on my dev machine, another little problem I have),
        but substantially less effort than the Qwt6 update.

        I'll get back to this sometime next week - no time to do this on
        weekends :).

        Cheers


        Dr Russell Standish Phone 0425 253119 (mobile)
        Principal, High Performance Coders
        Visiting Senior Research Fellow hpcoder@hpcoders.com.au
        Economics, Kingston University http://www.hpcoders.com.au


         
  • High Performance Coder

    SciDavIs now builds on Fedora 23/24: https://build.opensuse.org/package/show/home:hpcoder1/scidavis. Note, there is a patch needed for config.pri, which i haven't committed togithub yet.

     
  • Alexander Ploumistos

    This is great news!
    However, there are a number of files and folders missing from the rpms. When I tried patching version 1.14 I noticed that for some reason, anything defined in the "DESKTOP INTEGRATION" section of config.pri (appdata, desktop file, icons, etc.) disappeared from the buildroot. This is also the case for the plugins directory under lib/lib64. Perhaps something doesn't get passed along to qmake?

     
    • High Performance Coder

      On Sun, Aug 07, 2016 at 07:59:57AM +0000, Alexander Ploumistos wrote:

      This is great news!
      However, there are a number of files and folders missing from the rpms. When I tried patching version 1.14 I noticed that for some reason, anything defined in the "DESKTOP INTEGRATION" section of config.pri (appdata, desktop file, icons, etc.) disappeared from the buildroot. This is also the case for the plugins directory under lib/lib64. Perhaps something doesn't get passed along to qmake?

      I don't know what these files are, what they're used for, or how
      they're generated. AFAICT, the .spec file copies everything that is
      installed by "make install", which includes resources such as icons
      and translation files. What else is there?

      --


      Dr Russell Standish Phone 0425 253119 (mobile)
      Principal, High Performance Coders
      Visiting Senior Research Fellow hpcoder@hpcoders.com.au
      Economics, Kingston University http://www.hpcoders.com.au


       
      • Alexander Ploumistos

        I am attaching a diff of the unpatched config.pri in versions 1.D9 and 1-14 as well as the output of rpmdiff on the resulting packages. You can see that everything defined in that section is not included in the rpm in version 1-14.

        The following is from the build.log from when I tried to build 1.D13 (which has the same DESKTOP INTEGRATION section) on F23:

        Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.512XbD
        + umask 022
        + cd /builddir/build/BUILD
        + cd scidavis.1.D13
        + desktop-file-validate /builddir/build/BUILDROOT/scidavis-1.D13-1.fc23.x86_64//usr/share/applications/scidavis.desktop
        /builddir/build/BUILDROOT/scidavis-1.D13-1.fc23.x86_64//usr/share/applications/scidavis.desktop: file does not exist
        error: Bad exit status from /var/tmp/rpm-tmp.512XbD (%check)
        RPM build errors:
        Bad exit status from /var/tmp/rpm-tmp.512XbD (%check)
        Child return code was: 1

        Is config.pri generated by some tool, IDE or whatever?

         
        • Alexander Ploumistos

          I've dug a little deeper and it seems that the problem is that the variables in the "Desktop Integration" part of config.pri are actually undefined - at least on F23 with qt4 (see attached file). I think it's more important to focus on F24 & F25, so I'll first do some reading to get an idea about qmake and its peculiars and then try building on these targets. I don't have any experience with QT though, so I might be a while...

           
  • High Performance Coder

    • Group: 1.D13 --> 1.14
     
  • High Performance Coder

    • status: open --> fixed
     
  • High Performance Coder

    • status: fixed --> closed
     

Log in to post a comment.