Re: [Schrodinger-devel] [PATCH] Use VirtualAlloc() to allocate executable memory on Windows.

[Ramiro P. <ram...@gm...>]

On Fri, Mar 19, 2010 at 3:06 AM, David Schleef <ds...@en...> wrote:
> On Thu, Mar 18, 2010 at 10:00:04PM -0300, Ramiro Polla wrote:
>> $subj, not tested on pw32.
>>
>> This should make the allocated code executable so it may run from
>> Win64. But I assume there is no Win64 calling convention implemented
>> yet, so it still crashes all the time.
>
> Is memory allocated by malloc() not executable on Win64?

That's right, it's not executable.

> This patch is not acceptable as-is, since it removes the malloc()

This patch makes the malloc() case unused. It's still left there if
you want to reuse it later. From what I understood, only the win32
targets were using malloc(), right?

> case.  Would you like to fix it up, or would you like me to hack
> up an untested patch?  (By the way, the VirtualAlloc() does work
> on Win32, and I'm indifferent as to which method it uses.)

I'm too lazy to fix it up, I'd rather test the hacked up patch =). But
if it works on Win32 then it should work on Win64 as well (except for
the calling convention).