Menu
▾
▴
Re: [Scaffoldhunter-devel] Solved [Feature Request #38 : Split Subsets by Scaffolds On a Specified Level]
|
From: Till S. <til...@tu...> - 2014-04-11 16:28:41
|
Hi, thx for the patch. I just looked through the code and there was some misunderstanding regarding the task: - You selected the molecules of all scaffolds on ring level x and created a single subset from this. - The feature request 38 asked for something diferent: -> for each of the scaffolds on level x, select the molecules from the scaffold and his subtree and create a new subset. -> that means we will have n subsets if there are n scaffolds on level x. -> that means we partition the subset (minus the molecules from lower rings) The good message is, that your dialog seems to be reusable for this task. We just need to change the description. One small bug in the dialog: Only the visible rings are selectable, not the complete tree levels One further note: The action should be located in the subset menu and therefore should be implemented at the same place, where also the patch from najenson was imlemented (SubssetManager / SubsetActions). You can access the complete tree for a subset over DbManager.getScaffolds. Please wrap each of the DbManager calls in a DbExceptionHandler (you will find some examples in the SubsetManger). Regards, Till Am Mittwoch, 9. April 2014, 15:19:28 schrieb Shamshad Alam: > Hi, > > Feature Request #38 has been implemented, and you can find related patches > in attachment. > > When you will execute the application after applying patches, a tool bar > button (to make subset from ring) will appear at the right side of export > toolbar button. Follow that button to create a new subset at specified ring > level. > > Thanks > Shamshad > > -- Dipl.-Inf. Till Schäfer TU Dortmund University Chair 11 - Algorithm Engineering Otto-Hahn-Str. 14 / Room 237 44227 Dortmund, Germany e-mail: til...@cs... phone: +49(231)755-7706 fax: +49(231)755-7740 web: http://ls11-www.cs.uni-dortmund.de/staff/schaefer pgp: https://keyserver2.pgp.com/vkd/SubmitSearch.event?&&SearchCriteria=0xD84DED79 |
