#102 Configurable rendering of virtual scaffolds

[Nils Kriege]

An option should be added, which allows to choose between two rendering strategies:

• virtual scaffolds are rendered just as other scaffolds or
• virtual scaffolds are drawn in grey (currently implemented).

[Till Schäfer]

should this be a global setting or view specific?

[Lina Humbeck]

I think it would be useful for all views which depict scaffolds. There should be some additional rendering options. For example one should be able to configure the bond thickness and the font of the atom labels, e.g. bold.

[Till Schäfer]

yes, it makes sense for each view with scaffolds. However, my question was, whether it should be configurable for each view instance individually or whether it should be a global preference influencing all views at once?

[Lina Humbeck]

To be more flexible it should be view specific. Maybe it is possible to implement something like a checkbox, which if checked transfers the settings of the current view to the others.

[Philipp Mewes]

The scaffold-tree-view and the cloud-view are the only views affected by this feature, i think. I added a menu-item to the view-specific menus and created a toggle-button for the toolbar. Please have a look, if it looks ok (Commit [04fc38]).

[Philipp Mewes]

The feature is implemented for the scaffold-tree now. [f0fe11] contains the implementation.

[Philipp Mewes]

It worked similary for the cloud view. See this commit: [444acd]

[Till Schäfer]

There are two issues and one small design decision:

1. Only the background color of the semnatically zoom ---i.e., hidden--- structures is changed. Not the color of the scaffolds themselves. You may have a look at the highlighting (selection) code in order to see how you can color the bonds itself.
2. The setting is not stored in the session
3. I dislike the viual appearance of the icon (although i like the grey/black contrast). Maybe you can find some representation that is closer to the other icons. We can start with the minimize/maximize cursor-node icons (see atttachment). If we can create a similar icon, whith same sized ringes it might be a good starting point.

[Philipp Mewes]

1. Added the feature for the closest semantic zoom-level. See [3598c3].
2. Added the option to the view-state. Also the option is now applied after the tree has been built. See [5bcc4b].
3. Modified the icon. Instead of filled ovals, the contour-ovals, shown by the other toolbar-buttons, are used. See [9a227e].

[Till Schäfer]

a few minor things to change:
the grey ring color of the icon is hard to distinguish from black. We should re-use the light grey colors which are also used for the minimize/maximize cursor-node icons.
the default state of this feature should match the previous behavior. I.e., we should default to grey colors for virtual scaffolds. I would also reverse the toggle state.
* we should use a clearer description of the action. "marking" could be anything. Please make a german and english proposal here.

[Philipp Mewes]

[ef1471] updates the icon, [38586d] reverts the state of the button.
Since the button is used now to render all scaffolds with the same color, i would propose something like
Do not distinguish virtual scaffolds graphically or Display virtual scaffolds like other scaffolds
In German I would think of
Keine graphische Abgrenzung für virtuelle Scaffolds or Virtuelle Scaffolds wie andere Scaffolds darstellen

[Philipp Mewes]

The state of the toggle-button was not reverted in the CloudView so far. [8b7885] applies this feature.

[Till Schäfer]

we have discussed the names again, because the proposals seems to long. However, we only got a better solutions when negating the meaning of the button again. So we would like to have the description:

• Grey Out Virtual Scaffolds / Virtuelle Scaffolds Ausgrauen

We would like to keept the default (virtual scaffolds greyed out), but change the action back to be enabled if they are greyed out.

Sorry for the back and forth.

[Philipp Mewes]

Never mind, just had to remove four exclamation marks. Also updated the localisation. [d1b514] contains the updates.