Menu

#301 TableView: New columns are hidden by default after state restoring

next release
closed
5
2018-05-14
2018-04-17
No

When an update, that adds at least one new column to the table, is installed and an old session, which is still compatible with the new version of the software, is loaded, the new columns are hidden by default.
When restoring a state columns which are not part of the saved order are assumed as hidden and therefore not displayed.
It is not possible to separate between hidden columns and new columns from the current state.
Although this is a minor problem for the table itself, since new columns can be made visible with the column filter, this is not possible for the embedded table in the dendogram view.

Discussion

  • Philipp Mewes

    Philipp Mewes - 2018-04-18
    • status: open --> in-progress
     
  • Philipp Mewes

    Philipp Mewes - 2018-04-18
    • Blocks: feature #106 --> feature #108
     
  • Philipp Mewes

    Philipp Mewes - 2018-04-19

    Added a workaround to solve this problem without touching the view state ([2e79d1]).
    This avoids a break of session compatibility (although it would be ok for the next update) and adding further information to the view state which is not used in most cases. The workaround is only needed if new columns are added to the table by an update.

     

    Related

    Commit: [2e79d1]


    Last edit: Philipp Mewes 2018-05-08
  • Philipp Mewes

    Philipp Mewes - 2018-04-19
    • status: in-progress --> needs-review
     
  • Till Schäfer

    Till Schäfer - 2018-04-26
    • status: needs-review --> re-opened
     
  • Till Schäfer

    Till Schäfer - 2018-04-26
    • continue -> else (continue should never be used, when there is a single else block. it might make sense if the else blocks are white deep but here it just jas a bad readability)
    • floatingTable.getColumnModel().getColumn(floatingTable.getColumnCount() - 1);: does this work if you increase the maxColumn? Or will you just pick the same column multiple times?
    • this fix is independend from FR 108, right? if so, please rebase on master (otherwith i cannot merge it back to master)
     
  • Philipp Mewes

    Philipp Mewes - 2018-04-27
    • status: re-opened --> in-progress
     
  • Philipp Mewes

    Philipp Mewes - 2018-04-27

    (1) Changed this.
    (2) This was actually a bug. Invisible columns were not hidden. Fixed this ([eac507])
    (3) That's right. Unfortunately I'm currently not able to rebase. Message is "Rebase did nothing. HEAD was already up-to-date". Im trying to find a solution for this.

     

    Related

    Commit: [eac507]


    Last edit: Philipp Mewes 2018-05-08
  • Philipp Mewes

    Philipp Mewes - 2018-04-27
    • Blocks: feature #108 -->
     
  • Till Schäfer

    Till Schäfer - 2018-04-27
    • Blocks: FR 108 -->
     
  • Philipp Mewes

    Philipp Mewes - 2018-05-08

    After successfully rebasing the branch on master, i was not able to push the branch to its origin counterpart. Even not with the --force- or +-option. The changes can be found on the new branch bug-301-master([eac507]). I will also update the referenced commits in this discussion.

     

    Related

    Commit: [eac507]

  • Philipp Mewes

    Philipp Mewes - 2018-05-08
    • status: in-progress --> needs-review
     
  • Till Schäfer

    Till Schäfer - 2018-05-14
    • labels: --> session, table view
    • status: needs-review --> closed
    • Group: any future version --> next release
     
  • Till Schäfer

    Till Schäfer - 2018-05-14

    merged in [ec6136]

     

    Related

    Commit: [ec6136]


Log in to post a comment.

MongoDB Logo MongoDB