Menu

#286 TableViewState is restored in paint()

next release
closed
FR 79
5
2018-01-12
2017-07-17
No

The TableViewState for the TableView is restored when ViewComponent.paint() is called the first time. This seems to be motivated on the fact, that some configurations of the table cannot be applied until the table is painted.

However it should be checked, if there might be a cleaner solution. paint() is not the place where the session-loading is expected. At least, the code should be moved into a separate method applyState() to point out where the session is loaded.

Discussion

  • Till Schäfer

    Till Schäfer - 2017-09-06
    • assigned_to: Philipp Mewes
    • Group: any future version --> next release
     
  • Till Schäfer

    Till Schäfer - 2017-09-06

    please finish #79 before starting this bug.

     
  • Philipp Mewes

    Philipp Mewes - 2017-11-03
    • status: open --> in-progress
     
  • Philipp Mewes

    Philipp Mewes - 2017-11-10

    Moved the code to a separate method and alled it from the constructor. It seems to work without any issues. Also removed the paint()-override, which is redundant now.

    To be able to rebase this branch on feature-79, if necessary, I will not push the commit until feature #79 is completely finished.

     
  • Philipp Mewes

    Philipp Mewes - 2017-11-22
    • Depends On: --> feature #79
     
  • Till Schäfer

    Till Schäfer - 2018-01-11

    feature 79 is merged to master, can you please rebase on current master?

     
  • Philipp Mewes

    Philipp Mewes - 2018-01-12

    Rebased the branch on master and pushed it ([73ffd2]).

     

    Related

    Commit: [73ffd2]

  • Philipp Mewes

    Philipp Mewes - 2018-01-12
    • status: in-progress --> needs-review
     
  • Till Schäfer

    Till Schäfer - 2018-01-12
    • status: needs-review --> closed
    • Depends On: feature #79 --> FR 79
     
  • Till Schäfer

    Till Schäfer - 2018-01-12

    works as expected. merged in [aec96b].

     

    Related

    Commit: [aec96b]


Log in to post a comment.

MongoDB Logo MongoDB