Re: [Sc2-devel] Look Ma, no compiler warnings!

[Serge v. d. B. <sv...@st...>]

On Sat, 28 Dec 2002, Serge van den Boom wrote:
> On Sun, 22 Dec 2002, Steven Barker wrote:
> > On Sun, Dec 22, 2002 at 08:14:29PM +0100, Serge van den Boom wrote:
> > > Well, they might eliminate some warnings (not all though), but I think
> > > these warnings warrant some closer attention.
> > I agree with your caution.  I'll try to justify my patches as best I can.
> > I'm also curious about other compiler warnings you mention.  Those four
> > patches fix all the ones I see on my system (tested with both gcc 2.95.4
> > and 3.2.2pre2).
> They're mainly about negative shifts. We've actually got a patch lying here
> ready for that, but it will change the save game format, so we'll keep that
> for later, and apply it together with a number of other changes that affect
> the save game format later.
Correction: this bug has already been patched, without the save game format
being changed. It will however be handled in a different way eventually.

Serge