Re: [Sc2-devel] Look Ma, no compiler warnings!

[Serge v. d. B. <sv...@st...>]

On Sun, 22 Dec 2002, Steven Barker wrote:
> I've made a few patches to various files to eliminate all the compilers
> warnings that the build was generating.  Patches for the changes are at
> http://www.blckknght.org/~steve/uqm/
Well, they might eliminate some warnings (not all though), but I think
these warnings warrant some closer attention.

Why expand the size of MEM_HANDLE? Is that size actually needed?
Wouldn't a few type casts be better? I'd like to hear your rationale.

Putting an external function declaration inside a function is not good
practice. The right solution would be to include the correct .h file.

Your WRAP_VAL patch is downright wrong. (take a look at the actual
definition of the macro).

The NumVisits patch is correct. SBYTE is good enough though. Applied in that
form.

Greetings,

Serge