Re: [Sc2-devel] [PATCH] Speech that freezes the game...

[J <Sp...@th...>]

How were the oggs encoded?
Cause there are a great many options you can use when encoding them.
Possibly the lib that UQM uses to play ogg streams doesnt like some settings
?
I remember having those sorts of problems with MP3's when they first came
out, MP3's with odd bitrates/sample rates would cause
corruption/crashes/far-out behaviour in some decoding libraries..



----- Original Message -----
From: "Chris Gahan" <ch...@il...>
To: <sc2...@li...>
Sent: Friday, December 13, 2002 8:21 PM
Subject: [Sc2-devel] [PATCH] Speech that freezes the game...


> I'm not sure why this is, but talking with some people (the Starbase
> Commander, the talking pet, the Arilou) will freeze the game every time
when
> trying to play certain speech files. I found out that it's because the
> soundSource[SPEECH_SOURCE].sbuf_size is 0, and it just loops infinitely.
> It's weird since the speech file is there, and it plays fine in Winamp.
The
> problem is with the same speech file every time.
>
> Here's a quick patch. It adds a guard condition so that if there is
nothing
> in the sbuf, the game won't crash. It doesn't fix the underlying problem
of
> .oggs not playing, but it will make the game survive if some clever user
> screws up their .ogg files somehow. :)
>
> --- SNIP ---
>
> --- trackplayer.c 2002-12-13 02:12:30.000000000 -0500
> +++ trackplayer.c-new 2002-12-13 00:28:08.000000000 -0500
> @@ -304,7 +304,7 @@
>
>     for (;;)
>     {
> -    if (pos >= soundSource[SPEECH_SOURCE].sbuf_size)
> +    if (pos >= soundSource[SPEECH_SOURCE].sbuf_size &&
> soundSource[SPEECH_SOURCE].sbuf_size > 0)
>       pos = pos - soundSource[SPEECH_SOURCE].sbuf_size;
>      else
>       break;
>
> --- SNIP ---
>
>
> = Chris Gahan =============
>   (ch...@il...)
>
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by:
> With Great Power, Comes Great Responsibility
> Learn to use your power at OSDN's High Performance Computing Channel
> http://hpc.devchannel.org/
> _______________________________________________
> Sc2-devel mailing list
> Sc2...@li...
> https://lists.sourceforge.net/lists/listinfo/sc2-devel
>