Re: [Sc2-devel] strcpy to strncpy

[Abaddon <ab...@80...>]

ok, heres the thing...these fixes are to effect stability, in a proper
running environment they should never overrun anyways, and up to this
point everyone has been just hoping that was the case...these patches
are just to effect stability...more to the point they are to make the
propagation of bugs harder...

the original code doesn't even check to see if its going to fit, with
these patches it will always fit, it might crash a second later if its
not null terminated but it didn't trash your stack or your heap...the
problem is that this often doesn't crash the system but causes data
corruption...

tell you what, you guys decide how you want this fixed and ill fix it,
until then these patches are far far better than just not checking...

but when you do finally decide how this is best fixed, please please
please please, make sure everyone from then on out follows the
conventions because these patches, while i am more than happy to do
them, are very time consuming, boring, and tedious to make and test...

--Abaddon