|
From: Rainer M. <ra...@tb...> - 2006-06-09 15:46:21
|
Hi Stefan
I am currently going through the code, implementing the style convention
and getting familiar with SOSlib again :-)
in differentiateAST we have the lines
case AST_FUNCTION_ABS: /** ABS: WRONG */
/* f(x)=abs(a(x)) => f' = sig(a)*a'
WRONG: CAN RESULT IN A DISCONTINUOUS FUNCTION! */
ASTNode_setType(fprime, ASTNode_getType(f)); /* WRONG !!! */
ASTNode_addChild(fprime, differentiateAST(ASTNode_getChild(f,0),x));
break;
So it's actually not doing what it claims in the comment, and also there
are these uppercase WRONG warnings.
What should we do about that. Should we implement it as written in the
comment?
Rainer
|