#232 Bug in comp v1 spec

closed
5
2014-04-05
2012-12-09
No

In the UML diagram in the comp v1 spec it refers to the element by name "sbaseRef". However in the code snippets in Section 3.7.2 the name used for the elements is sBaseRef.

Note the RNG schema uses sbaseRef but libSBML currently uses sBaseRef; so any models produced by libSBML are invalid as far as the schema is concerned :-)

We need to decide which version of the spelling we consider correct.

I vote sbaseRef.

Discussion

  • Michael Hucka

    Michael Hucka - 2012-12-10

    I am accepting this issue as valid.

     
  • Chris Myers

    Chris Myers - 2012-12-10

    I am accepting this issue as valid.

     
  • Chris Myers

    Chris Myers - 2012-12-10

    I strongly support sBaseRef due to the problems it would cause with compatibility with models already generated. I think if we want to change this in a later version which includes a way convert, then I would be okay with the change. However, we cannot change it now without substantial disruption.

     
  • Nicolas Le Novère

    I am accepting this issue as valid.

     
  • Nicolas Le Novère

    I would go the sBaseRef way. It is more consistent.

     
  • Nicolas Le Novère

    • status: open --> pending
     
  • Lucian Smith

    Lucian Smith - 2012-12-21

    There's some trickiness here in terms of who is actually in charge of making changes to the spec of a package. In the absence of anything else, I'm going on the theory that the package working group decides amongst themselves, then makes a proposal to the SBML editors for approval. That's what we're in the middle of doing now; the comp PWG has a survey out, and once that's done, will revise the spec and submit it to the SBML editors for approval. (For what it's worth, the two top vote-getters right now are 'both ways are acceptable, but one is marked 'canonical' and the other is 'deprecated'.)

     
  • Michael Hucka

    Michael Hucka - 2013-01-03
    • labels: 1552177 --> Level 3 Version 1 Package
    • milestone: --> 678078
    • assigned_to: nobody --> luciansmith
     
  • Lucian Smith

    Lucian Smith - 2013-01-04

    The vote is in, and the decision was to make 'sBaseRef' canonical, and to make 'sbaseRef' legal but deprecated. I am working now on new text for the change for the next version of the spec.

     
  • Lucian Smith

    Lucian Smith - 2013-01-04

    The vote is in, and the decision was to make 'sBaseRef' canonical, and to make 'sbaseRef' legal but deprecated. I am working now on new text for the change for the next version of the spec.

     
  • Lucian Smith

    Lucian Smith - 2013-03-04
    • milestone: 678078 --> Accepted:_Changes_with_conformance_implications
    • status: pending --> closed
     
  • Lucian Smith

    Lucian Smith - 2013-03-04

    Fixed in R2.

     
  • Lucian Smith

    Lucian Smith - 2014-04-05
    • labels: Level 3 Version 1 Package --> Level 3 Version 1 Package: comp
    • Group: Accept-conformanc-implication --> Accept-conformance-implications
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks