#220 Validation rule 20401 has redundancy with 10311

closed
5
2014-05-27
2012-06-22
No

SBML L3v1Core p. 144 and 150.

As discovered by Lucian Smith in the context of issue #3476019, validation rules 10311 and 20401 have overlap: Both of them state "The value of the attribute id in a UnitDefinition object must conform to the syntax of the SBML type UnitSId". 20401 also adds the condition that the identifier must not be identical to certain other identifiers. This is actually a bad thing because it means that whatever trips 10311 must always also trip 20401.

A possible solution would be to remove the duplicate statement in 20401.

Discussion

  • Michael Hucka

    Michael Hucka - 2012-06-22

    My feeling is that the better change is to remove the redundancy from the text of rule 20401. Rule 10311 is in a block of rules all concerned with syntax of identifiers, so IMHO it makes more sense to leave it there, and remove the syntax statements from rule 20401, leaving 20401 to talk about the uniqueness of identifiers.

     
  • Chris Myers

    Chris Myers - 2012-06-22

    I am accepting this issue as valid.

     
  • Lucian Smith

    Lucian Smith - 2012-06-22

    I am fine removing the redundancy from either place.

     
  • Lucian Smith

    Lucian Smith - 2012-06-22

    I agree with the proposed change and that it should be done.

     
  • Sarah Keating

    Sarah Keating - 2012-06-24

    I agree with the proposed change and that it should be done.

     
  • Michael Hucka

    Michael Hucka - 2012-06-26
    • milestone: 678078 --> Accepted:_Changes_with_conformance_implications
    • status: open --> pending
     
  • Michael Hucka

    Michael Hucka - 2013-12-09
    • status: pending --> accepted
    • Group: Accept-conformanc-implication --> Accept-conformance-implications
     
  • Lucian Smith

    Lucian Smith - 2014-05-27

    Fixed in SVN for L3v2, and will be part of the forthcoming release of that specification.

     
  • Lucian Smith

    Lucian Smith - 2014-05-27
    • status: accepted --> closed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks