#360 C++ Namespace Wrapping

libSBML-5.8.0
closed
nobody
2015-01-22
2013-03-05
Anonymous
No

In libSBML 5.8 (and maybe previous versions) there is a problem when using cmake. Running cmake with -DWITH_CPP_NAMESPACE=yes will give output which claims that the namespace wrapping is enabled. This is indeed true with the library is compiled (confirmed with nm on the object files). However, the installed header will not have LIBSBML_USE_CPP_NAMESPACE defined.
The configure scripts

Additionally, it is rather rude that the default behaviour is to _not_ have the namespace wrapping enabled. The logic should be reversed.

Discussion

  • Frank Bergmann

    Frank Bergmann - 2015-01-20

    NOTICE NOTICE NOTICE
    The comments associated with this ticket were lost in late 2014.
    The SBML Team manually recovered the comments. The text is appended below.
    NOTICE NOTICE NOTICE


    Comment By: Frank Bergmann (fbergmann)
    Date: 2013-03-05 09:15

    Message:
    Thank you for your feedback. I agree in so far, that once the namespace
    wrapping is enabled, the installed header files should reflect that.

    However, I feel the default cannot change, as this would cause trouble for
    the language bindings, and would cause incompatibilities for our users.

    best

    Frank

     
  • Sarah Keating

    Sarah Keating - 2015-01-22

    The installed header will now reflect when the namespace is enabled.

    As far as enabling the ns by default; historically libsbml users requested that this did not happen. So I'm afraid the namespace being disabled by default will remain the status quo.

    Sarah

     
  • Sarah Keating

    Sarah Keating - 2015-01-22
    • status: open --> closed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks